tests: enable core24 plugin tests #5209
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Issue raised: #5207 Signed-off-by: Sergio Schvezov <[email protected]>
- Remove the dotnet test for core24 from build and run - Move the dotnet plugin test to the plugin suite Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
bepri
approved these changes
Jan 17, 2025
|
@bepri I still need to move those other python tests! |
tigarmo
reviewed
Jan 17, 2025
spread.yaml
Outdated
| tests/spread/core24-suites/plugins/: | ||
| summary: core24 plugin tests | ||
| systems: | ||
| - ubuntu-24.04* |
There was a problem hiding this comment.
do these tests build destructively?
One argument "pro" using something lower than 24.04 is that it lets us catch failures in classic snaps
| SNAP/colcon_msg_package: colcon-msg-package | ||
|
|
||
| systems: | ||
| - ubuntu-22.04 |
There was a problem hiding this comment.
these are using 22.04, is that on purpose?
There was a problem hiding this comment.
no, but I will drop it from here and make the suite use 22.04
There was a problem hiding this comment.
fwiw, they could be handled by the global suite systems filter, which I switched to 22.04, but these tests will not work on non amd64 or arm64, so the filter is more specific
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Signed-off-by: Sergio Schvezov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tox run -m lint?tox run -e test-py310? (supported versions:py39,py310,py311,py312)